While many landlords have done well in recent decades, the investment case for buy-to-let is being questioned more than ever.